Skip to content
This repository has been archived by the owner on Feb 12, 2019. It is now read-only.

Fetch combination of tweets from user and query #321

Closed
wants to merge 1 commit into from
Closed

Fetch combination of tweets from user and query #321

wants to merge 1 commit into from

Conversation

hamidnazari
Copy link

For example, tweets from and to a specific user, or tweets from specific users and a certain hashtag.
e.g.

          username: "seaofclouds",
          query: "@seaofclouds",

OR

          username: ["seaofclouds", "hamidnazari"],
          query: "#fifaworldcup2010",

@purcell
Copy link
Collaborator

purcell commented Jan 6, 2013

Thanks for taking the time to submit this!

I personally find this behaviour a little confusing, because your description above implies an "AND" query, yet the code apparently results in an "OR" search query.

All in all, I think I prefer to make people enter a full search string in the "query" parameter, and ignore the username if "query" is supplied. I like that users can go to "search.twitter.com" and use the advanced search options to build a query, then simply copy it into the "query" param.

As a result, I'm going to decline this request, but I really appreciate your contribution!

-Steve

@purcell purcell closed this Jan 6, 2013
@hamidnazari
Copy link
Author

No worries. Thank you for taking the time to explain.

Fair enough. I personally didn't find the query building method intuitive enough.

Ironically the AND in daily English is rather the opposite of the AND in programming context. So is OR.

@purcell
Copy link
Collaborator

purcell commented Jan 6, 2013

Really? I find the English sense of AND and OR to be consistent with those terms usage in programming.

Whatever the case, I've added a comment to the examples that will hopefully make things clearer for users in future.

Thanks again!

@hamidnazari
Copy link
Author

Well yeah it depends from what perspective you look at it.

Say in a list of items (tweets in my case), item1 AND item2 are "two"
items. It's additive.
When it comes to criteria and fulfilling conditions (as seen in
programming), an AND actually makes the list shorter. It's not additive
anymore.
That was what my point.

Thanks anyways, Steve. I think updating the documentation was a good
outcome.

On Mon, Jan 7, 2013 at 1:48 AM, Steve Purcell notifications@github.comwrote:

Really? I find the English sense of AND and OR to be consistent with those
terms usage in programming.

Whatever the case, I've added a comment to the examples that will
hopefully make things clearer for users in future.

Thanks again!


Reply to this email directly or view it on GitHubhttps://github.com//pull/321#issuecomment-11929256.

@purcell
Copy link
Collaborator

purcell commented Jan 7, 2013

Aha, I see what you mean! Yes, that's odd. I guess the trick is that the "AND" refers to the addition of the conditions, not of the results.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants