bugfix: Lock is not acquired when multiple branches have cross locks#1247 #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1338 +/- ##
=============================================
+ Coverage 48.63% 48.64% +<.01%
- Complexity 1643 1645 +2
=============================================
Files 332 332
Lines 11521 11527 +6
Branches 1424 1425 +1
=============================================
+ Hits 5603 5607 +4
Misses 5297 5297
- Partials 621 623 +2
Continue to review full report at Codecov.
|
zjinlei
changed the title
slievrly
reviewed
Jul 23, 2019
| canLock &= false; | ||
| break; |
There was a problem hiding this comment.
why break?
db: lock1:xid1 lock2:xid2 lock3:xid1
request: lock1:xid1 lock2:xid1 lock3:xid1
lock3 can add in dbExistedRowKeys?
There was a problem hiding this comment.
db: lock2:xid2
request: lock2:xid1
These two global transactions are different. You cannot get the lock this time.
add break is a quick failure
zhangthen
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
bugfix #1247
Ⅱ. Does this pull request fix one issue?
fixes #1247
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews