bugfix: serialize the type of timestamp lost nano value #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1443 +/- ##
============================================
+ Coverage 45.68% 45.7% +0.02%
Complexity 1664 1664
============================================
Files 345 345
Lines 12641 12666 +25
Branches 1588 1589 +1
============================================
+ Hits 5775 5789 +14
- Misses 6220 6228 +8
- Partials 646 649 +3
Continue to review full report at Codecov.
|
slievrly
reviewed
Aug 12, 2019
|
|
||
| @Override | ||
| public void serializeWithType(Timestamp timestamp, JsonGenerator gen, SerializerProvider serializers, TypeSerializer typeSerializer) throws IOException { | ||
| gen.setCurrentValue(timestamp); |
There was a problem hiding this comment.
I will try to check the api to think is it necessary.
slievrly
reviewed
Aug 12, 2019
| } catch (IOException e) { | ||
| LOGGER.error("deserialize java.sql.Timestamp error : {}", e.getMessage(), e); | ||
| } | ||
| Timestamp timestamp = new Timestamp(arrayNode.get(0).asLong()); |
There was a problem hiding this comment.
should it be in the catch block?
There was a problem hiding this comment.
yes, thanks for correct my mistake
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Jackson would use DateSerializer to handle java.sql.Timestamp(Timestamp extend from Date). So when java.sql.Timestamp has nano second, the digits would lost(java.util.Date dost not support nano second)
I provide customize serializer and deserializer. When serialize java.sql.Timestamp I convert it to a long array include fastTime and nanoSecond, look like this
finally use it rebuild java.sql.Timestamp when deserialize.
Ⅱ. Does this pull request fix one issue?
#1434
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews