-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: nacos namespace setting does not take effect #1539
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1539 +/- ##
============================================
- Coverage 46.45% 46.3% -0.15%
Complexity 1692 1692
============================================
Files 347 347
Lines 12719 12719
Branches 1591 1564 -27
============================================
- Hits 5908 5889 -19
- Misses 6171 6173 +2
- Partials 640 657 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
bugfix: nacos namespace setting does not take effect
Ⅱ. Does this pull request fix one issue?
fix #1536
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews