Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: nacos namespace setting does not take effect #1539

Merged
merged 3 commits into from
Aug 27, 2019

Conversation

cmonkey
Copy link
Contributor

@cmonkey cmonkey commented Aug 27, 2019

Ⅰ. Describe what this PR did

bugfix: nacos namespace setting does not take effect

Ⅱ. Does this pull request fix one issue?

fix #1536

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 27, 2019

Codecov Report

Merging #1539 into develop will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1539      +/-   ##
============================================
- Coverage      46.45%   46.3%   -0.15%     
  Complexity      1692    1692              
============================================
  Files            347     347              
  Lines          12719   12719              
  Branches        1591    1564      -27     
============================================
- Hits            5908    5889      -19     
- Misses          6171    6173       +2     
- Partials         640     657      +17
Impacted Files Coverage Δ Complexity Δ
...obuf/convertor/BranchRegisterRequestConvertor.java 88% <0%> (-8%) 3% <0%> (ø)
...buf/convertor/GlobalLockQueryRequestConvertor.java 92.59% <0%> (-7.41%) 3% <0%> (ø)
...obuf/convertor/GlobalRollbackRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...otobuf/convertor/GlobalStatusRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...otobuf/convertor/GlobalCommitRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...protobuf/convertor/RegisterTMRequestConvertor.java 95.45% <0%> (-4.55%) 3% <0%> (ø)
...protobuf/convertor/RegisterRMRequestConvertor.java 91.66% <0%> (-4.17%) 3% <0%> (ø)
...otobuf/convertor/BranchReportRequestConvertor.java 92.59% <0%> (-3.71%) 3% <0%> (ø)
...otobuf/convertor/BranchCommitRequestConvertor.java 96.42% <0%> (-3.58%) 3% <0%> (ø)
...obuf/convertor/BranchRollbackRequestConvertor.java 92.85% <0%> (-3.58%) 3% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c71be4d...cbc229e. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix: Nacos namespace setting does not take effect (#1536) bugfix: nacos namespace setting does not take effect (#1536) Aug 27, 2019
@slievrly slievrly changed the title bugfix: nacos namespace setting does not take effect (#1536) bugfix: nacos namespace setting does not take effect Aug 27, 2019
@slievrly slievrly merged commit 3ec2dfb into apache:develop Aug 27, 2019
@cmonkey cmonkey deleted the feature/fix-1563 branch August 27, 2019 08:19
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nacos namespace setting does not take effect
5 participants