-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: once delete GlobalSession locks for db mode when commit success #1574
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1574 +/- ##
=============================================
+ Coverage 46.42% 46.44% +0.02%
- Complexity 1714 1717 +3
=============================================
Files 350 350
Lines 12829 12847 +18
Branches 1615 1618 +3
=============================================
+ Hits 5956 5967 +11
- Misses 6225 6232 +7
Partials 648 648
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews