-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: enhance test coverage of seata common #2007
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2007 +/- ##
=============================================
+ Coverage 55.34% 55.58% +0.23%
- Complexity 2506 2522 +16
=============================================
Files 445 445
Lines 14838 14838
Branches 1749 1749
=============================================
+ Hits 8212 8247 +35
+ Misses 5863 5827 -36
- Partials 763 764 +1
|
add Copyright on new Classes |
resolved |
common/src/main/java/io/seata/common/exception/EurekaRegistryException.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
Enhance the test coverage of seata-common module.
Ⅱ. Does this pull request fix one issue?
It's a partial fix of #187 .
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Run tests and coverage of seata-common module.
Ⅴ. Special notes for reviews