Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enhance test coverage of seata common #2007

Merged
merged 15 commits into from
Dec 17, 2019

Conversation

EZKAYOTWJPRKXWCUYEEB
Copy link
Contributor

Ⅰ. Describe what this PR did

Enhance the test coverage of seata-common module.

Ⅱ. Does this pull request fix one issue?

It's a partial fix of #187 .

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Run tests and coverage of seata-common module.

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 10, 2019

Codecov Report

Merging #2007 into develop will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2007      +/-   ##
=============================================
+ Coverage      55.34%   55.58%   +0.23%     
- Complexity      2506     2522      +16     
=============================================
  Files            445      445              
  Lines          14838    14838              
  Branches        1749     1749              
=============================================
+ Hits            8212     8247      +35     
+ Misses          5863     5827      -36     
- Partials         763      764       +1
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 27% <0%> (-1%)
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (+0.31%) 29% <0%> (ø) ⬇️
...eata/common/exception/EurekaRegistryException.java 100% <0%> (+100%) 4% <0%> (+4%) ⬆️
...io/seata/common/exception/DataAccessException.java 100% <0%> (+100%) 6% <0%> (+6%) ⬆️
...a/common/exception/ShouldNeverHappenException.java 100% <0%> (+100%) 4% <0%> (+4%) ⬆️
...seata/common/exception/NotSupportYetException.java 100% <0%> (+100%) 4% <0%> (+4%) ⬆️

@zjinlei
Copy link
Contributor

zjinlei commented Dec 10, 2019

add Copyright on new Classes

@EZKAYOTWJPRKXWCUYEEB
Copy link
Contributor Author

add Copyright on new Classes

resolved

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei zjinlei merged commit 6035d08 into apache:develop Dec 17, 2019
@EZKAYOTWJPRKXWCUYEEB EZKAYOTWJPRKXWCUYEEB deleted the test_common_1 branch December 17, 2019 05:01
@wangliang181230 wangliang181230 added this to the 1.0.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants