Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: saga statemachine designer add default properties for 'catch' node #2178

Merged

Conversation

long187
Copy link
Contributor

@long187 long187 commented Jan 13, 2020

Ⅰ. Describe what this PR did

Optimize: saga statemachine designer add default properties for 'catch' node.

Many user feedback added the catch node, but did not catch the exception,
the reason is because they don't configure the type of exception to catch. So the designer fills in "java.lang.Throwable" by default

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei added this to the 1.1.0 milestone Jan 15, 2020
@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #2178 into develop will increase coverage by 0.02%.
The diff coverage is 24.13%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2178      +/-   ##
=============================================
+ Coverage      54.42%   54.45%   +0.02%     
- Complexity      2469     2471       +2     
=============================================
  Files            445      445              
  Lines          14742    14736       -6     
  Branches        1734     1733       -1     
=============================================
  Hits            8024     8024              
+ Misses          5957     5954       -3     
+ Partials         761      758       -3
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/io/seata/rm/tcc/TwoPhaseResult.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...a/io/seata/rm/tcc/api/BusinessActivityContext.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/io/seata/rm/tcc/remoting/parser/DubboUtil.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../main/java/io/seata/rm/tcc/TCCResourceManager.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../rm/tcc/remoting/parser/DefaultRemotingParser.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/rm/tcc/interceptor/ActionInterceptorHandler.java 25.37% <25%> (ø) 7 <5> (ø) ⬇️
...io/seata/rm/tcc/interceptor/ActionContextUtil.java 54.54% <54.54%> (+1.76%) 5 <3> (ø) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 62.9% <0%> (-0.81%) 24% <0%> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 47.65% <0%> (+0.39%) 28% <0%> (+1%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 84.61% <0%> (+0.48%) 68% <0%> (+1%) ⬆️

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lovepoem lovepoem merged commit c796f8d into apache:develop Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants