Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: saga statemachine status incorrect on register branch failed #2249

Conversation

long187
Copy link
Contributor

@long187 long187 commented Feb 14, 2020

Ⅰ. Describe what this PR did

StateMachineInstance status is still RU when register branch error, It should be FA/UN.

Ⅱ. Does this pull request fix one issue?

#2247

@codecov-io
Copy link

codecov-io commented Feb 14, 2020

Codecov Report

Merging #2249 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2249   +/-   ##
==========================================
  Coverage      50.11%   50.11%           
  Complexity      2665     2665           
==========================================
  Files            517      517           
  Lines          17038    17038           
  Branches        2065     2065           
==========================================
  Hits            8538     8538           
  Misses          7688     7688           
  Partials         812      812

@long187 long187 added this to the 1.1.0 milestone Feb 16, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix:saga statemachine status incorrect on register branch failed bugfix: saga statemachine status incorrect on register branch failed Feb 17, 2020
@slievrly slievrly merged commit 23d98f9 into apache:develop Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants