Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize some default configuration value #2255

Merged
merged 4 commits into from
Feb 17, 2020
Merged

optimize: optimize some default configuration value #2255

merged 4 commits into from
Feb 17, 2020

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

optimize: optimize some default configuration value

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly added this to the 1.1.0 milestone Feb 17, 2020
Signed-off-by: slievrly <slievrly@163.com>
@jovany-wang
Copy link
Contributor

Codecov Report

Merging #2255 into develop will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2255      +/-   ##
=============================================
- Coverage      50.08%   49.97%   -0.11%     
- Complexity      2660     2663       +3     
=============================================
  Files            518      518              
  Lines          17030    17011      -19     
  Branches        2061     2022      -39     
=============================================
- Hits            8530     8502      -28     
+ Misses          7691     7681      -10     
- Partials         809      828      +19     
Impacted Files Coverage Δ Complexity Δ
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0.00%> (-9.53%) 3.00% <0.00%> (ø%)
...otobuf/convertor/BranchReportRequestConvertor.java 90.90% <0.00%> (-9.10%) 3.00% <0.00%> (ø%)
...obuf/convertor/BranchRollbackRequestConvertor.java 92.00% <0.00%> (-8.00%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0.00%> (-7.41%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0.00%> (-5.27%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterRMRequestConvertor.java 90.47% <0.00%> (-4.77%) 3.00% <0.00%> (ø%)
...tobuf/convertor/BranchReportResponseConvertor.java 95.45% <0.00%> (-4.55%) 3.00% <0.00%> (ø%)
... and 21 more

@codecov-io
Copy link

codecov-io commented Feb 17, 2020

Codecov Report

Merging #2255 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2255      +/-   ##
=============================================
+ Coverage      50.08%   50.12%   +0.03%     
- Complexity      2660     2664       +4     
=============================================
  Files            518      518              
  Lines          17030    17030              
  Branches        2061     2061              
=============================================
+ Hits            8530     8536       +6     
+ Misses          7691     7689       -2     
+ Partials         809      805       -4
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/core/constants/DefaultValues.java 0% <ø> (ø) 0 <0> (ø) ⬇️
server/src/main/java/io/seata/server/Server.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../java/io/seata/core/rpc/netty/NettyBaseConfig.java 36.11% <100%> (ø) 2 <0> (ø) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 84.44% <0%> (+0.44%) 73% <0%> (+1%) ⬆️
...o/seata/server/coordinator/DefaultCoordinator.java 54.87% <0%> (+0.51%) 29% <0%> (+1%) ⬆️
...java/io/seata/tm/api/DefaultGlobalTransaction.java 70% <0%> (+4.44%) 21% <0%> (+2%) ⬆️

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 9ed91f6 into apache:develop Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants