Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix worker size not support enum type and some minor problem #2270

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Feb 19, 2020

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: fix worker size not support enum type and some minor problem

Ⅱ. Does this pull request fix one issue?

fix #2268 #2238

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@jovany-wang
Copy link
Contributor

jovany-wang commented Feb 19, 2020

Codecov Report

Merging #2270 into develop will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2270   +/-   ##
==========================================
  Coverage      50.11%   50.12%           
- Complexity      2662     2665    +3     
==========================================
  Files            518      518           
  Lines          17030    17031    +1     
  Branches        2061     2062    +1     
==========================================
+ Hits            8534     8536    +2     
- Misses          7689     7690    +1     
+ Partials         807      805    -2     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/GlobalSession.java 84.44% <0.00%> (+0.44%) 73.00% <0.00%> (+1.00%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 54.87% <0.00%> (+0.51%) 30.00% <0.00%> (+2.00%) ⬇️

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit f8d3916 into apache:develop Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

too many config logs output
4 participants