optimize: optimize transaction context switch logic when transaction mode switching #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
booogu
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #2307 +/- ##
=============================================
+ Coverage 51.78% 51.83% +0.04%
- Complexity 2698 2701 +3
=============================================
Files 517 517
Lines 16767 16776 +9
Branches 2034 2033 -1
=============================================
+ Hits 8683 8695 +12
+ Misses 7275 7271 -4
- Partials 809 810 +1 |
zjinlei
reviewed
Mar 6, 2020
| return false; | ||
| } | ||
|
|
||
| if (RootContext.inGlobalTransaction() && !RootContext.getBranchType().equals(String.valueOf(BranchType.AT.ordinal()))) { |
...aga-engine-store/src/main/java/io/seata/saga/engine/store/db/DbAndReportTcStateLogStore.java
Outdated
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/annotation/GlobalTransactional.java
Outdated
Show resolved
Hide resolved
tm/src/main/java/io/seata/tm/api/transaction/TransactionInfo.java
Outdated
Show resolved
Hide resolved
|
@q294881866 PTAL tcc |
q294881866
approved these changes
Mar 6, 2020
l81893521
reviewed
Mar 11, 2020
jsbxyyx
reviewed
Mar 12, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/exec/ExecuteTemplate.java
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Optimize transaction context behavior when transaction mode is switched:
1.remove interceptorType context variable.
2.add branchType context variable and use it to distinguish different branch transaction modes.(distinguish TCC Mode and AT Mode)
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews