Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: repackage spring-boot-starter #2601

Merged
merged 3 commits into from
Apr 24, 2020
Merged

optimize: repackage spring-boot-starter #2601

merged 3 commits into from
Apr 24, 2020

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

optimize: repackage spring-boot-starter

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #2601 into develop will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2601      +/-   ##
=============================================
- Coverage      51.17%   51.03%   -0.14%     
  Complexity      2804     2804              
=============================================
  Files            554      554              
  Lines          17772    17755      -17     
  Branches        2099     2062      -37     
=============================================
- Hits            9094     9061      -33     
+ Misses          7819     7812       -7     
- Partials         859      882      +23     
Impacted Files Coverage Δ Complexity Δ
...n/java/io/seata/common/util/StringFormatUtils.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...ta/spring/boot/autoconfigure/StarterConstants.java 96.29% <ø> (ø) 1.00 <0.00> (ø)
...utoconfigure/properties/client/LockProperties.java 53.84% <ø> (ø) 4.00 <0.00> (?)
...autoconfigure/properties/client/LogProperties.java 60.00% <ø> (ø) 2.00 <0.00> (?)
.../autoconfigure/properties/client/RmProperties.java 47.61% <ø> (ø) 5.00 <0.00> (?)
...configure/properties/client/ServiceProperties.java 54.54% <ø> (ø) 6.00 <0.00> (?)
...onfigure/properties/client/ShutdownProperties.java 60.00% <ø> (ø) 2.00 <0.00> (?)
...ure/properties/client/ThreadFactoryProperties.java 45.94% <ø> (ø) 8.00 <0.00> (?)
.../autoconfigure/properties/client/TmProperties.java 55.55% <ø> (ø) 3.00 <0.00> (?)
...nfigure/properties/client/TransportProperties.java 52.00% <ø> (ø) 7.00 <0.00> (?)
... and 42 more

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit fef2785 into apache:develop Apr 24, 2020
xiaowan pushed a commit to xiaowan/seata that referenced this pull request Apr 30, 2020
@slievrly slievrly added this to the 1.3.0 milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants