-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: ColumnUtils delEscape with scheme error. #2875
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2875 +/- ##
=============================================
- Coverage 50.13% 50.10% -0.04%
+ Complexity 3022 3017 -5
=============================================
Files 598 598
Lines 19304 19297 -7
Branches 2350 2351 +1
=============================================
- Hits 9678 9668 -10
+ Misses 8664 8662 -2
- Partials 962 967 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
大佬 我们在整合seata时遇到了很多问题.其中一个问题就是这个schema '数据库名'.'表名' 我们自己定位delxxx那个方法上手动改变成去除" |
Ⅰ. Describe what this PR did
fix ColumnUtils#delEscape like `scheme`.`table` error, optimize KeywordChecker checkAndReplace method.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews