bugfix: nacos-config.py script could not run with namespace #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
将!=改成<= 即可
Codecov Report
@@ Coverage Diff @@
## develop #2932 +/- ##
=============================================
- Coverage 50.28% 50.27% -0.02%
+ Complexity 3063 3062 -1
=============================================
Files 600 600
Lines 19503 19503
Branches 2404 2403 -1
=============================================
- Hits 9807 9805 -2
Misses 8712 8712
- Partials 984 986 +2
|
l81893521
added
first-time contributor
|
@luorenjin modify the pr title in En. |
|
请修改标题为英文，并且以bugfix: 开头 |
l81893521
changed the title
|
<=似乎依然不行，使用python nacos-config.py 192.168.168.128:1111 返回python nacos-config.py nacosAddr， |
|
namespace是可选参数，个人感觉应该是<2 |
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Oct 22, 2020
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
将!=改成<= 即可
Ⅰ. Describe what this PR did
运行：python nacos-config.py 172.16.xxx.xxx:31263 seata
提示：python nacos-config.py nacosAddr
看逻辑得知，请求的参数数量判断逻辑错误了
源逻辑：
if len(sys.argv) != 2: print ('python nacos-config.py nacosAddr') exit()修改后：
if len(sys.argv) <= 2: print ('python nacos-config.py nacosAddr') exit()可以正确执行，带 namespace 参数的命令
Ⅱ. Does this pull request fix one issue?
自己发现的
Ⅲ. Why don't you add test cases (unit test/integration test)?
修改后保存：
执行 python nacos-config.py 172.16.xxx.xxx:31263 seata 成功，数据正确写入了nacos
Ⅳ. Describe how to verify it
查看命令窗口日志，并查看nacos配置，是否正确写入
Ⅴ. Special notes for reviews