-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: null exception when sql columns is empty in insert on duplicate #5033
Merged
funky-eyes
merged 3 commits into
apache:develop
from
renliangyu857:bugfix_nullexception_wheninsertcolumnempty_ininsertondup
Oct 29, 2022
Merged
bugfix: null exception when sql columns is empty in insert on duplicate #5033
funky-eyes
merged 3 commits into
apache:develop
from
renliangyu857:bugfix_nullexception_wheninsertcolumnempty_ininsertondup
Oct 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5033 +/- ##
=============================================
+ Coverage 49.06% 49.24% +0.17%
- Complexity 4092 4111 +19
=============================================
Files 733 733
Lines 26004 26005 +1
Branches 3211 3212 +1
=============================================
+ Hits 12759 12805 +46
+ Misses 11887 11839 -48
- Partials 1358 1361 +3
|
slievrly
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
funky-eyes
changed the title
bugfix:null exception when sql columns is empty in insert on duplica…
bugfix: null exception when sql columns is empty in insert on duplicate
Oct 28, 2022
funky-eyes
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
slievrly
pushed a commit
to opentrx/seata
that referenced
this pull request
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module/rm-datasource
rm-datasource module
multilingual
type: bug
Category issues or prs related to bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…te executor
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5005
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews