assert_match broke backword comatibillity. #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change is intentional. The bug is in rubygems tests. I've fixed that too and will reapply my minitest changes once I have everything settled on all sides... Thanks! |
szuecs
pushed a commit
to szuecs/ruby
that referenced
this pull request
Dec 11, 2013
matcher and obj are String. fix r35541. [Bug ruby#6405] DON'T COMMIT IF YOU CAN'T RUN TEST. FIX AS SOON AS POSSIBLE YOU BREAK TESTS. patched by ayumin. minitest/minitest#124 * lib/minitest/unit.rb (refute_match): ditto. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35563 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlove
pushed a commit
to tenderlove/ruby
that referenced
this pull request
Jan 24, 2014
matcher and obj are String. fix r35541. [Bug ruby#6405] DON'T COMMIT IF YOU CAN'T RUN TEST. FIX AS SOON AS POSSIBLE YOU BREAK TESTS. patched by ayumin. minitest/minitest#124 * lib/minitest/unit.rb (refute_match): ditto. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35563 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see aloso:
https://bugs.ruby-lang.org/issues/6405