Troubles with Tablet Mode

[phitschhd]

Hi,
first of all thank you for this great project!
Device: HP Elite X2 G8 (with detachable keyboard)
Describe Problem: When i detach my keyboard, then ChromeOS goes correctly in the tablet-mode, but the onscreen keyboard doesn’t appear and the auto rotate is also not available. If i activate the force_enable_tablet mode in the brunch framework settings the tablet mode works perfectly (with onscreen keyboard and also the rotation) but the detachable keyboard doesn’t work (i cannot make any inputs) when i connect it to the tablet. Except the f keys and the touchpad from the keyboard works when force_tablet_mode is enabled.

[phitschhd]

Update: I managed it to work properly by adding the right kernel (04F3:0C79) for my device in the /lib/udev/rules.d/99-tablet-mode.rules file.
@sebanc could you please add
ACTION=="add", SUBSYSTEMS=="hid", KERNEL=="*:04F3:0C79.*" , RUN+="/bin/bash -c 'echo 0 > /sys/bus/platform/devices/tablet_mode_switch.0/tablet_mode'"
ACTION=="remove", SUBSYSTEMS=="hid", KERNEL=="*:04F3:0C79.*" , RUN+="/bin/bash -c 'echo 1 > /sys/bus/platform/devices/tablet_mode_switch.0/tablet_mode'" in the 99-tablet-mode.rules file so that I don't have to change it every time I do a brunch update?

[sebanc]

Hi,

Your patch is included in brunch r119 stable release.

[phitschhd]

Hi, thanks, appreciate your work! :)

[tenda96]

hi could you please add mine too? (is a dell latitude 5290 2in1)

ACTION=="add", SUBSYSTEMS=="hid", KERNEL==":044E:1218." , RUN+="/bin/bash -c 'echo 0 > /sys/bus/platform/devices/tablet_mode_switch.0/tablet_mode'"
ACTION=="remove", SUBSYSTEMS=="hid", KERNEL==":044E:1218." , RUN+="/bin/bash -c 'echo 1 > /sys/bus/platform/devices/tablet_mode_switch.0/tablet_mode'"

Thank you and thanks for your work!
Let me know :)