Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] sendOnEnter doesn't seem to work #15

Closed
bennichols opened this issue Jun 28, 2022 · 2 comments
Closed

[Bug] sendOnEnter doesn't seem to work #15

bennichols opened this issue Jun 28, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@bennichols
Copy link

Describe the bug

Thanks for the great lib! I'm trying to use the sendOnEnter functionality, but it seems to have no effect. No matter what I do, the enter key always starts a new line. Looking through the code, I don't see this used at all except in the onSubmitted callback, and I can't seem to figure out where/if it's ever called.

To Reproduce

Steps to reproduce the behavior:

  1. Using the base demo.
  2. Add the sendOnEnter option to InputOptions.
  3. Run the app and hit enter.
  4. You'll see a new line instead of submitting the text as is.

Expected behavior

I expect the text to be sent when hitting the "return" key (and ideally this would be set to "enter" or "send" instead in this mode).

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

  • OS: Mac
  • Device: iPhone SE Emulator
  • Language Version: 2.17.5
  • Software/library Version 0.0.7

Additional context

Add any other context about the problem here.

@bennichols bennichols added the bug Something isn't working label Jun 28, 2022
@bennichols bennichols changed the title [Bug] Your title [Bug] sendOnEnter doesn't seem to work Jun 28, 2022
@SebastienBtr
Copy link
Owner

Hey! thanks I'll take a look

@SebastienBtr
Copy link
Owner

Thanks, it has been fixed in version 0.0.8 with commit: e6477f9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants