Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some form components missing a disabled state #30

Closed
3 of 4 tasks
mario-subo opened this issue Jun 10, 2019 · 1 comment · Fixed by #48
Closed
3 of 4 tasks

Some form components missing a disabled state #30

mario-subo opened this issue Jun 10, 2019 · 1 comment · Fixed by #48
Labels
🐛 Bug Something isn't working 🚀 Release

Comments

@mario-subo
Copy link
Contributor

mario-subo commented Jun 10, 2019 •
edited by yousifalraheem
Loading

Describe the bug
The following components should have, but are missing a disabled state.

  • Rating
  • Slider
  • Timepicker
  • Toggle
@mario-subo mario-subo added the 🐛 Bug Something isn't working label Jun 10, 2019
@mario-subo mario-subo added this to the v1.0.2 milestone Jun 10, 2019
@yousifalraheem yousifalraheem removed this from the v1.2.0 milestone Sep 16, 2019
yousifalraheem added a commit that referenced this issue Sep 16, 2019
@yousifalraheem
feat(rating, slider): added disabled state and fixed bugs
d08b29a 
Added disabled state to both rating and slider components. Also fixed few bugs

"fix #30"
@yousifalraheem yousifalraheem mentioned this issue Sep 22, 2019
Merged
@sebopensource
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Something isn't working 🚀 Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor/general cleanup seb-oss/react-components
3 participants
@yousifalraheem @sebopensource @mario-subo