Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_CLEAR_ button for tag filtering requires text for users #304

Closed
horus68 opened this issue Nov 21, 2016 · 5 comments
Closed

_CLEAR_ button for tag filtering requires text for users #304

horus68 opened this issue Nov 21, 2016 · 5 comments

Comments

@horus68
Copy link
Contributor

horus68 commented Nov 21, 2016

When using search with activated navigation filter for tags, the text _CLEAR_ shows up as a button to allow clear tag filtering.
2016-11-21 14_36_28-recent additions
or
2016-11-21 14_43_13-adicionados recentemente

This doesn't look good to me. Also it should be a translatable text!

Side question: is it possible to have tag filtering as an option for local config file, not only by user setting?

@horus68
Copy link
Contributor Author

horus68 commented May 24, 2019

this involves the file \util.js
line 201
$("#filter ul").append ("<li>_CLEAR_</li>");
line 256

function handleFilterEvents () {
    $("#filter ul").on ("click", "li", function(){
        var filter = $(this).text ();
        if (filter === "_CLEAR_") {
            filterList = {};
            $("#filter ul li").removeClass ("filter-exclude");
            $("#filter ul li").removeClass ("filter-include");
            doFilter ();
            return;
        }

Now the question is: how to make this into a language variable so its possible to translate?
@seblucas

@seblucas
Copy link
Owner

@horus68 should be fixed, could you update Transifex with the new translation string : "filter.clearall' I think I forgot how to do that.

I guess that the translation maybe automatic for many languages (as Clear All should be used in other projects). As usual I can do french and italian if Transifex cannot do that automatically.

@horus68
Copy link
Contributor Author

horus68 commented Jun 22, 2019

@seblucas Transifex source updated now.
Will wait until 24 june to make a PR with the new translations so translators can have some time to translate!

@seblucas
Copy link
Owner

Great, in any case I'll make a release tomorrow as starting friday, I'll be away for a two week work trip in Africa and I won't have time to work on COPS.

@horus68
Copy link
Contributor Author

horus68 commented Jun 23, 2019

@seblucas I have added a PR for translations (and another for icons).
Hope you find the time to include them in the new release so its easier for all to download and use.

Have a safe return!

dunxd pushed a commit to dunxd/mikespub-cops that referenced this issue Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants