Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including HTTP_USER_AGENT for ebookdroid android app #243

Merged
merged 3 commits into from
Jan 15, 2016
Merged

Including HTTP_USER_AGENT for ebookdroid android app #243

merged 3 commits into from
Jan 15, 2016

Conversation

horus68
Copy link
Contributor

@horus68 horus68 commented Jan 13, 2016

Including HTTP_USER_AGENT for android apps
Ebookdroid https://play.google.com/store/apps/details?id=org.ebookdroid
org.ebookdroid 2.3.5

this is related to issue #236

=Update: below listed apps was not included following discussion below.
They will require changes on user agents from the apps developer!

FullReader+ https://play.google.com/store/apps/details?id=com.fullreader
Reader/2.3.1(java)

PocketBook reader https://play.google.com/store/apps/details?id=com.obreey.reader
Dalvik/2.1.0

Including HTTP_USER_AGENT for android apps

FullReader+ https://play.google.com/store/apps/details?id=com.fullreader
Reader/2.3.1(java)

PocketBook reader https://play.google.com/store/apps/details?id=com.obreey.reader
Dalvik/2.1.0

Ebookdroid https://play.google.com/store/apps/details?id=org.ebookdroid
org.ebookdroid 2.3.5

regarding issue #236
@seblucas
Copy link
Owner

I'm afraid I won't be able to merge it. org.ebookdroid is perfectly fine as it's unique.

But reader is a very generic name so there's a risk to redirect to the OPDS stream with some exotic browser.
Same remark with Dalvik which is the name of the Java VM on Android prior to 6.0.

The only way to add these 2 apps is to contact their authors to ask them to change their user agent (like Ebookdroid did for example).

Sorry, If you update your PR to keep only ebookdroid, I can still merge it.

@horus68
Copy link
Contributor Author

horus68 commented Jan 14, 2016

Ok, PR edited to ebookdroid only.
I already have contacted developers asking them to make a change on this.
Same on other apps not listed here (I've been testing all free android apps for epub readers)

@seblucas
Copy link
Owner

Another nitpick (sorry for not thinking about that earlier). I'd prefer if you use org\.ebookdroid (with the backslash). It should work fine and it'll be safer (as the . has a special meaning with regular expressions).

@horus68 horus68 changed the title Including HTTP_USER_AGENT for 3 more android apps Including HTTP_USER_AGENT for ebookdroid android app Jan 14, 2016
@horus68
Copy link
Contributor Author

horus68 commented Jan 14, 2016

Changed and working as advised!

seblucas added a commit that referenced this pull request Jan 15, 2016
Including HTTP_USER_AGENT for ebookdroid android app
@seblucas seblucas merged commit 6ad4d34 into seblucas:master Jan 15, 2016
@seblucas
Copy link
Owner

Thanks

@horus68 horus68 deleted the patch-2 branch January 15, 2016 15:03
dunxd pushed a commit to dunxd/mikespub-cops that referenced this pull request Sep 10, 2023
Including HTTP_USER_AGENT for ebookdroid android app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants