added view button to view pdf&epub in the browser #374
Conversation
|
Hi, Thanks for this PR, it seems mostly good. I'll check that out locally and get back to you. |
|
As a side note, EPUB support on Edge is very picky (many epub I own despite being perfectly valid are not read by Edge) |
|
Yes, the EPUB support on Edge is also slow when the file gets large. Hopefully it will get better as it's heavily invested by Microsoft currently. |
|
Sorry for the delay and thanks again |
Add icons to make things easier to handle. Add hints to all button. Don't limit to PDF / EPUB, if someone has a FB2 / Mobi reader in its browser / PC let it use it
|
Downloading (map icon) does not work on symlinked libraries, only on real paths. |
|
Hi Mario, What do you mean ? Is there a difference between the download and the open icons ? I never used a symlink for my libraries but I see no reason for a discrepancy here. |
|
Hi Sebastien, Normally I see no difference. However on a symlinked library he "epub" icon works nomally, but the "map" icon gives a "file not found". I use firefox on the desktop. The same error with webkit on iOS. |
Add icons to make things easier to handle. Add hints to all button. Don't limit to PDF / EPUB, if someone has a FB2 / Mobi reader in its browser / PC let it use it
…eblucas#374 The PR seblucas#374 was badly tested by me and did not include anything for URL Rewriting :(.
Now that major browsers support viewing pdf(Firefox&Edge) and epub(Edge and Firefox w/ extension) files directly from inside the browsing window, it's my own needs to leverage this functionality for reading ebooks on phones. It might be helpful to others as well.
It's my first time to touch PHP code. Feel free change it.