Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve modal component by adding toggleOverflow and transition options #255

Merged
merged 6 commits into from
Jul 17, 2020
Merged

Improve modal component by adding toggleOverflow and transition options #255

merged 6 commits into from
Jul 17, 2020

Commits on Jul 16, 2020

  1. fix: add overflow auto to modal__dialog element

    @sebnitu
    sebnitu committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    15b43f2 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. feat: add toggle overflow option to modal component

    @sebnitu
    sebnitu committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    cf66a92 View commit details
    Browse the repository at this point in the history

  2. refactor: move open and close transitions into their own methods

    @sebnitu
    sebnitu committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    fd82ef6 View commit details
    Browse the repository at this point in the history

  3. test: add delay helper to tests as needed

    @sebnitu
    sebnitu committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    125094c View commit details
    Browse the repository at this point in the history

  4. feat: add option to disable transitions on modal component

    @sebnitu
    sebnitu committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    9a68328 View commit details
    Browse the repository at this point in the history

  5. chore: run build

    @sebnitu
    sebnitu committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    429b642 View commit details
    Browse the repository at this point in the history