Improve modal component by adding toggleOverflow and transition options #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are a few missing core features on the modal component such as the ability to toggle the
overflow:hiddenon elements and the ability to disable transitions.Solution
This PR adds two new feature options:
toggleOverflow (default: 'body')- Toggleoverflow:hiddenon all matching elements provided by the CSS selector. Set to falsy to disable.transition (default: true)- Toggle the transition animation for the modal. Set tofalseto disable which will only ever apply thestateOpenedandstateClosedstates and ignorestateOpeningandstateClosing.