Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible improvement in documentation of Cumulative dynamic AUC #425

Closed
melodiemonod opened this issue Jan 10, 2024 · 1 comment
Closed

Comments

@melodiemonod
Copy link

melodiemonod commented Jan 10, 2024

In the documentation https://scikit-survival.readthedocs.io/en/stable/api/generated/sksurv.metrics.cumulative_dynamic_auc.html

It would make the denominator more interpretable if it was written as $$(\sum_{i = 1}^n \sum_j^n I(y_j > t) I(y_i \leq t) \omega_i)$$ instead of $$(\sum_{i = 1}^n I(y_i > t))(\sum_i^n I(y_i \leq t) \omega_i)$$.

@sebp
Copy link
Owner

sebp commented Jan 14, 2024

Mathematically, you are correct. I think it's easier to understand in its current form, because the ROC curve compares sensitivity and specificity. The first term $\sum_{i=1} I(y_i > t)$ is related to the denominator of the specificity, and the term $\sum_{i=1} I(y_i \leq t) \omega_i$ to the denominator of the specificity.

@sebp sebp closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants