Add pickle test for PacketList [ready]

[polybassa]

edited by gpotter2

This PR:

• fix NamedTuple (and PacketList) pickling on Python < 3.7

[polybassa]

@gpotter2 This is related to NamedTuple. Do you have an idea if this is fixable?

[gpotter2]

This looks like an annoying bug. It also only appears to be present on older python 3 versions :/ I'll have a look if I get the time

[polybassa]

Thanks. I looked a little bit into it, but it would require a redefinition of NamedTuple in compat in case of Python version < 3.6.
As far as I understood this bug, the NamedTuple lambda is not sufficient for pickle. I checked a little bit for simple solutions, but unfortunately I couldn't find any. So I assume, a class NamedTuple implementation with some black magic in __init__ or __new__ is necessary to solve this.

[polybassa]

Closing this PR, since I can not finish it.

[gpotter2]

I will

[gpotter2]

I think it's easier to just implement custom pickling. Let's see how this works

[codecov]

Codecov Report

Merging #3113 (eeac021) into master (a4dcd78) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3113      +/-   ##
==========================================
+ Coverage   85.05%   85.26%   +0.20%     
==========================================
  Files         256      261       +5     
  Lines       54303    54425     +122     
==========================================
+ Hits        46189    46407     +218     
+ Misses       8114     8018      -96     

Impacted Files	Coverage Δ
scapy/compat.py	95.42% <100.00%> (+43.67%)	⬆️
scapy/packet.py	83.17% <100.00%> (+0.96%)	⬆️
scapy/contrib/automotive/enumerator.py	43.87% <0.00%> (-7.85%)	⬇️
scapy/arch/windows/__init__.py	67.73% <0.00%> (-0.38%)	⬇️
scapy/layers/sixlowpan.py	86.31% <0.00%> (-0.26%)	⬇️
scapy/layers/tls/automaton_cli.py	70.82% <0.00%> (-0.10%)	⬇️
scapy/utils.py	78.30% <0.00%> (-0.07%)	⬇️
scapy/plist.py	86.31% <0.00%> (ø)
scapy/contrib/automotive/uds_logging.py	71.56% <0.00%> (ø)
scapy/contrib/automotive/graph.py	66.66% <0.00%> (ø)
... and 30 more

[polybassa]

Really nice solution. Thanks. --

…

On March 11, 2021 3:12:38 PM GMT+01:00, Gabriel ***@***.***> wrote: I think it's easier to just implement custom pickling. Let's see how this works -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: #3113 (comment)