-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pickle test for PacketList [ready] #3113
Conversation
6890be3
to
3630aba
Compare
@gpotter2 This is related to NamedTuple. Do you have an idea if this is fixable? |
This looks like an annoying bug. It also only appears to be present on older python 3 versions :/ I'll have a look if I get the time |
Thanks. I looked a little bit into it, but it would require a redefinition of |
Closing this PR, since I can not finish it. |
I will |
I think it's easier to just implement custom pickling. Let's see how this works |
Codecov Report
@@ Coverage Diff @@
## master #3113 +/- ##
==========================================
+ Coverage 85.05% 85.26% +0.20%
==========================================
Files 256 261 +5
Lines 54303 54425 +122
==========================================
+ Hits 46189 46407 +218
+ Misses 8114 8018 -96
|
Really nice solution. Thanks.
--
…On March 11, 2021 3:12:38 PM GMT+01:00, Gabriel ***@***.***> wrote:
I think it's easier to just implement custom pickling. Let's see how
this works
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
#3113 (comment)
|
* Add pickle test for PacketList * test different NamedTuple for pickle * Improve pickling Co-authored-by: gpotter2 <gabriel@potter.fr>
* Add pickle test for PacketList * test different NamedTuple for pickle * Improve pickling Co-authored-by: gpotter2 <gabriel@potter.fr>
edited by gpotter2
This PR:
NamedTuple
(andPacketList
) pickling on Python < 3.7