New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLL Runtime Test Failures #72

Open

eee4017 opened this issue Feb 4, 2021 · 1 comment

Assignees

Contributor

eee4017 commented Feb 4, 2021 •

edited

Loading

Try to fix failures in soll runtime test, there is mainly 4 class of failures. All of them are elaborated in the notion note.

Failures below seem like bugs during the compile time, we need to fix the bugs in the soll compiler:

Failed operation (wrong answers)
Out-of-bound Access

Failures below caused by different environment setup compared to the solc testing environment:

Host environment: Host constants should be setup correctly
Incorrect test cases: the inevitable differences between the compiler object. We should modify the test case to fit the answer.

eee4017 self-assigned this

eee4017 mentioned this issue

[Test] Fixing soll-runtime-test #75

Merged

Contributor Author

eee4017 commented May 5, 2021

Most of the runtime tests are fixed in #75 , while these tests remain as future work

./libyul/yulInterpreterTests/recursive_function_for_loop recursive function are not optimized by SOLL, this should fix the optimizer.
./libyul/yulInterpreterTests/external_call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment