Ledger BTC integration #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import ledger stx
Import BTC and Ordinals together from Ledger
Create transaction screens for BTC
…on into ledger-btc-mvp
…as clicked continue on external inputs screen
yknl
requested review from
victorkirov,
m-aboelenein and
teebszet
and removed request for
victorkirov
…-recipients Allow multiple recipients in Ledger BTC flow
…ate-ordinals-display-issue Fix ordinals display issue
…extension into ledger-btc-mvp
…on into ledger-btc-mvp
m-aboelenein
approved these changes
Jul 20, 2023
|
|
||
| ``` | ||
| cd ../xverse-core && npm i && npm run build:esm && \ | ||
| cd $OLDPWD && npm i --legacy-peer-deps @secretkeylabs/xverse-core@../xverse-core && npm start |
There was a problem hiding this comment.
xverse-core lib doesn't require --legacy-peer-deps flag
yknl
reviewed
Jul 20, 2023
| address.length - 4, | ||
| address.length, | ||
| )}`; | ||
| return `${address.substring(0, 4)}...${address.substring(address.length - 4, address.length)}`; | ||
| } | ||
| } | ||
|
|
||
| export function getShortTruncatedAddress(address: string) { |
There was a problem hiding this comment.
This one is a little confusing, shouldn't the 4 character one above be the shorter truncated address?
There was a problem hiding this comment.
In general I think we need more characters shown for the addresses. 6 characters from beginning and end would be better.
yknl
approved these changes
Jul 20, 2023
dhriaznov
pushed a commit
that referenced
this pull request
Jul 9, 2024
…scriptions ord_getInscriptions request support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.