Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grabbing linux-docker which is too new for configuration file. #19

Closed
psgivens opened this issue Sep 4, 2018 · 3 comments
Closed

Grabbing linux-docker which is too new for configuration file. #19

psgivens opened this issue Sep 4, 2018 · 3 comments

Comments

@psgivens
Copy link

psgivens commented Sep 4, 2018

AWS has evolved. This grep will now the pull the latest version of the docker linux. This is incompatible with the app-version.json file supplied because it complains that this value needs to be 2
"AWSEBDockerrunVersion": "1",

I suggest changing this code:

jq -r '.SolutionStacks[]' | grep -P '.+Amazon Linux.+Docker.+' | head -1)"

to this:

jq -r '.SolutionStacks[]' | grep -P '.+Amazon Linux.+Docker.+v2\.7.+' | head -1)"
@jvehent
Copy link
Member

jvehent commented Sep 4, 2018

Or maybe we could keep the grep as it is, and bump app-version.json to version 2?

@psgivens
Copy link
Author

That would be recommended if you want to continue to maintain this repo. i.e. if it were a real project.

The grep update relieves you of the obligation to watch for changes in AWS, while providing a repo that your readers can use without breaking. i.e. Are you going to notice, and update, this repo when a new version of docker requires a new version of the app-version?

@jvehent
Copy link
Member

jvehent commented Jan 19, 2019

fixed in f2678d0

@jvehent jvehent closed this as completed Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants