-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dossier - Displaying dates for Superior and Subordinate Organizations? #39
Comments
@evz @tonysecurityforcemonitor I'm missning the ex: https://sfm.datamade.us/api/organizations/eda35997-21d0-4d53-a923-e9984c76afd0/ These are in the api documentation: https://github.com/security-force-monitor/sfm-proxy/blob/master/docs/organizations.md |
@evz @sam-ffctn - in theory the date_first_cited and date_last_cited would only apply to the "immediate" parent/child organizations - would that cut down the list of organizations displayed in the dossier? For instance this organization (link) has quite a few organizations listed, like the 195 Battalion, which are not direct children, but rather "grandchildren" (child of a child) or "great grandchildren". Or put another way - would this mean switching from "who are all the descendants of this organization?" to "who is a child of this organization?" It's fine if it does (and doesn't complicate anything else, like the Chart), but if it's going to cause issues then we might scrap... |
@tonysecurityforcemonitor displaying the grandchildren shouldn't have any impact on the dates being displayed. I'm not exactly sure if we want to only show the direct children/parents of an organization. If we do, we should open up this in another issue, it shouldn't be too difficult to solve. |
@sam-ffctn - I thinking only showing direct children/parents in the dossier would make the dates a bit clearer in my mind so let's do that - I'll create a separate issue for that. |
@sam-ffctn Thanks for the fix on only showing direct children/parents - now the only thing remaining on this issue is displaying the |
@tonysecurityforcemonitor @evz I'm waiting for the API include those values, as I mentioned above.
|
OK, |
Yep this is working |
@sam-ffctn - Can we display the dates for the superior and subordinate organizations in the mini and full dossiers? That extra context would be quite helpful.
The text was updated successfully, but these errors were encountered: