Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New term requests: maximum Adams order and maximum BDF order #19

Closed
jonrkarr opened this issue Feb 3, 2016 · 4 comments
Closed

New term requests: maximum Adams order and maximum BDF order #19

jonrkarr opened this issue Feb 3, 2016 · 4 comments

Comments

@jonrkarr
Copy link
Collaborator

jonrkarr commented Feb 3, 2016

As discussed on the sed-ml mailing list:

https://sourceforge.net/p/sed-ml/mailman/message/34816341/

it turns out that there are situations where a single algorithm must use two different 'maximum order' terms; one for maximum adams order, and a second for maximum BDF order. I know you just added 'maximum order' (at my request--thank you!); can you now add maximum Adams order and maximum BDF order as children of 'maximum order'? Thank you!

Reported by: luciansmith

@jonrkarr
Copy link
Collaborator Author

jonrkarr commented Feb 3, 2016

Hi Lucian,

I have found out (sorry, that I have not looked better before when adding 'maximum order') that these parameters are already described as KISAO_0000220 ('LSODA maximum non-stiff order', synonym: 'Adams max order'), and KISAO_0000219 ('LSODA maximum stiff order', synonym: 'BDF max order'). However, they are LSODA-specific now. Would it be OK, if instead of creating new terms, I generalise the definition of these ones?

Original comment by: annazhukova

@jonrkarr
Copy link
Collaborator Author

jonrkarr commented Feb 3, 2016

Aha! I had looked for them myself, but also hadn't found them. Sure, that'd be perfect. And this is why I needed 'maximum order' in the first place, so feel free to back out 'maximum order' entirely, if that makes sense, and if we caught it in time.

Original comment by: luciansmith

@jonrkarr
Copy link
Collaborator Author

jonrkarr commented Feb 3, 2016

  • status: open --> closed
  • assigned_to: Anna Zhukova

Original comment by: annazhukova

@jonrkarr
Copy link
Collaborator Author

jonrkarr commented Feb 3, 2016

Fixed in KiSAO version 2.3.10

Original comment by: annazhukova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants