-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installing should package #22
Comments
This is definitely a dependency, not a dev or peer one. I probably think it'd be easier to simply list the methods where they are necessary. |
@ruiquelhas can you take of this? https://github.com/seegno/jscs-config-seegno/blame/master/src/rules/require-should-assertion-execution.js#L8 we can either cache this or mark this a dependency instead. |
We have the same issue for I'm not sure if it's a good idea to move them to the dependencies, so I would suggest to just add |
I have a better solution for this I think - invoke the |
Not solved by #23. We still need to implement @ruimarinho suggestion. |
Since
should
package is registered as adevDependency
andpeerDependency
, anyone that follows the instructions and isn't usingshould
runs into anUNMET PEER DEPENDENCY
warning followed by aCannot find module 'should'
error when running jscs.The package is used in the
requireShouldAssertionExecution
rule, so I think we have two options:should
fromdevDependencies
todependencies
.should
to the installation instructions on README.md.The text was updated successfully, but these errors were encountered: