This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
fix(puppeteer): Wait until networkidle2 for better dev server support #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to
networkidle2
during Puppeteer navigation, preventing timeouts when requesting pages that are served from webpack-dev-server and similar tools (which can keep open event-source sockets for HMR, etc).The
networkidle2
event is fired when there are no more than 2 network connections for at least 500 ms. If the page you're requesting is expected to have less than 2 resources that stall for longer than 500ms you can switch back tonetworkidle0
using the new--puppeteer-wait-until
option.Fixes #62