This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
fix(puppeteer): Wait until networkidle2 for better dev server support #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches to networkidle2 during Puppeteer navigation, preventing timeouts when requesting pages that are served from webpack-dev-server (which holds open event-source sockets for HMR). The networkidle2 event is fired when there are no more than 2 network connections for at least 500 ms. If the page you're requesting has less than 2 resources that stall for longer than 500ms, and doesn't complete loading you can switch back to networkidle0 using the new `--puppeteer-wait-until` option. Fixes #62
toolmantim
changed the title
markdalgleish
approved these changes
Oct 1, 2018
|
🤦🏼♂️ Oh dear, I see that I completely forgot about the docs! Thanks for the addition @markdalgleish 🙏🏼 |
markdalgleish
changed the title
|
🎉 |
|
Available now in v0.6.2. Thanks so much for the PR! 🙌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to
networkidle2during Puppeteer navigation, preventing timeouts when requesting pages that are served from webpack-dev-server and similar tools (which can keep open event-source sockets for HMR, etc).The
networkidle2event is fired when there are no more than 2 network connections for at least 500 ms. If the page you're requesting is expected to have less than 2 resources that stall for longer than 500ms you can switch back tonetworkidle0using the new--puppeteer-wait-untiloption.Fixes #62