Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RealTimeClient Updates #16

Open
ghost opened this issue Nov 30, 2017 · 2 comments
Open

RealTimeClient Updates #16

ghost opened this issue Nov 30, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Nov 30, 2017

What is the best way to update this library. I am not familiar with github?

I have made some fixes locally on your lib for real time sockets and also your auth mechanism seemed to be incorrect (passphrase and signature was the wrong way around).

Should I fork or send a PR?

@tekmaven
Copy link

tekmaven commented Dec 13, 2017

@Lucasmaximus you should fork, commit and push the changes to your fork, and then create the pull request. For more information, see this github doc: https://help.github.com/articles/creating-a-pull-request-from-a-fork/

It also looks like this has already been done in #14. This issue can be closed.

@ghost
Copy link
Author

ghost commented Dec 15, 2017

TBH I've made a lot more changes now, and just decided to keep a local fork for my own purposes (Most of the authentication logic between GDAX and BitcoinAverage is basically the same so I basically made that much more generic and pulled a lot of that into a new C# project).

Thanks for the link to the manual, I normally use TFS (not online) so I dunno the procedure.

Glad the issue was fixed for someone else though 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant