Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJS Retry improvements for 500 and 429, normal and batch #1084

Merged
merged 17 commits into from
Sep 17, 2024

Conversation

MichaelGHSeg
Copy link
Contributor

@MichaelGHSeg MichaelGHSeg commented May 6, 2024

  • I've included a changeset (psst. run yarn changeset. Read about changesets here).

Copy link

changeset-bot bot commented May 6, 2024

🦋 Changeset detected

Latest commit: a6352bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@segment/analytics-next Minor
@segment/analytics-core Minor
@segment/analytics-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelGHSeg MichaelGHSeg marked this pull request as ready for review May 17, 2024 17:10
@MichaelGHSeg MichaelGHSeg changed the title In progress tests for batch and fetch retry improvements Retry improvements for 500 and 429, normal and batch May 17, 2024
@MichaelGHSeg MichaelGHSeg changed the title Retry improvements for 500 and 429, normal and batch AJS Retry improvements for 500 and 429, normal and batch May 17, 2024
danieljackins
danieljackins previously approved these changes May 29, 2024
Copy link
Contributor

@danieljackins danieljackins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Needs a changeset

Copy link
Contributor

@silesky silesky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small comments but LGTM

@MichaelGHSeg MichaelGHSeg merged commit 5647624 into master Sep 17, 2024
5 of 6 checks passed
@MichaelGHSeg MichaelGHSeg deleted the MichaelGHSeg/ajs-retry-betterments branch September 17, 2024 15:23
@github-actions github-actions bot mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants