Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add circle jobs to test installation with go get #138

Closed
wants to merge 1 commit into from
Closed

add circle jobs to test installation with go get #138

wants to merge 1 commit into from

Conversation

nickatsegment
Copy link
Contributor

No description provided.

@nickatsegment nickatsegment mentioned this pull request Sep 21, 2018
Merged
@eculver
Copy link

eculver commented Sep 21, 2018

LGTM, but it looks like this should depend on #123 otherwise this will generate new go.{mod,sum} every time its run w/ GO111MODULE=on.

eculver
eculver approved these changes Sep 21, 2018
View reviewed changes
Copy link

@eculver eculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest waiting for and rebasing on #123.

@nickatsegment nickatsegment mentioned this pull request Sep 26, 2018
Merged
@nickatsegment
Copy link
Contributor Author

Superseded by #144

@alberts alberts deleted the add-test-for-go-get branch February 14, 2019 01:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eculver eculver eculver approved these changes

@systemizer systemizer systemizer approved these changes

@anastassia-b anastassia-b Awaiting requested review from anastassia-b

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickatsegment @eculver @systemizer