Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Settings for better performance #119

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Refactor Settings for better performance #119

merged 1 commit into from
Aug 22, 2019

Conversation

khos2ow
Copy link
Member

@khos2ow khos2ow commented Aug 18, 2019

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request enhances existing functionality.
  • This pull request introduces breaking change.

For more information, see the Contributing Guide.

Description

This PR enhances settings.Settings and better use of pointer to get the better performance.

Issues Resolved

List any existing issues this pull request resolves.

Checklist

Put an x into all boxes that apply:

Tests

  • I have added tests to cover my changes.
  • All tests pass when I run make test.

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Code Style

  • My code follows the code style of this project.

@khos2ow khos2ow mentioned this pull request Aug 18, 2019
Merged
10 tasks
@metmajer metmajer merged commit 1c0d7b5 into terraform-docs:master Aug 22, 2019
@khos2ow khos2ow deleted the enhance-settings branch August 22, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khos2ow @metmajer