-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fdsnxml2inv: inconsistent timespan behavior when agregating location #75
Comments
We will check it. |
The sensor location merges all channels with the same geo location (lat, lon, elev) in one epoch spanning all of the channel epochs. But here we have an issue. As the geo location is part of the sensor location element and not the stream and the index of the sensor location is code and start, the following set cannot be represented:
The index is ("", 2011-07-19T10:55:00) and only one sensor location can exist with that index. But one item (HHE) has a different (may erroneous) geo location and we cannot have two sensor locations with the same index. Thus a conflict. |
Can we close the issue? |
Judging from the updated inventory for station CPOZ the answer is probably "yes". ;) Nevertheless there may be better ways to handle this kind of inventory errors. We have also seen this several times, even in GSN inventories (e.g. inconsistent sensor depths), and it can be a pain to debug. The fdsnxml2inv strategy seems to be to try to repair this, but as we can see the result is not always satisfactory. Fixing the issue upstream is the right way and in order to make this more likely to actually happen, fdsnxml2inv should not attempt to repair this but either
|
Feedback from the original author of the issue would be nice if the issue is solved or not. |
Hi @gempa-jabe and @jsaul ! I confirm that we now able to handle the station after we have corrected the metadata. However, the scope of this issue was a bit different. That is, a somewhat inconsistent behaviour to handle this case during conversion. I'll try to summerize our point:
The problem I see here is that there seems not to be one single and consistent strategy, see the details of the
This inconsistent translation leads to unexpected behaviour, but makes it extremly difficult to understand what exactly is going on and to debug such situation. At first it seems the epochs have been included. There is only one tiny detail, which makes the difference and access to data does not work anymore. This issue is about avoiding this inconsistency and support clearer reporting to users. We think we understand now the fundamental cause of why |
@gempa-jabe @petrrr |
This is not really what I intended to say. However, FDSN StationXML in principle would allow to allow to (1) provide slightly different coordinates for different streams under the same location code e.g. sensor a vs. sensor b (short period vs. broad band vs. accelerometer); different cooridinates could be also different depth. Not necessary good practice, but possibile in StationXML, and not directly translatable to SC Inventory; (2) provide slightly different coordinates for different epochs; this case probably is more common when a sensor needed to be moved slightly. In FDSN StationXML, it would be possible to keep the location code and just specify the new coordinates; Such a StationXML file is not directly translatable to SC Inventory. As mentioned already, I do not argue for such a practice or would encourage it. But we may see such metadata. In StationXML this can be represented but not translated into SC Inventory. Anyway, I am not too worried about this fact. We will deal with this. This issue was only about keeping the behaviour consistent and transparent, and to avoid hidden issues with the inventory, which then are difficult to debug. |
This report is derived from an observation we did while resoving an webservices problem.
Our station inventory is managed as native FDSN StationXML and converted into SC Inventory XML as part of the configuration process. In one specific case the coordinates for different epochs differ, while the location code remains unchaged. We understand that while FDSN does not define rules on the exact usage of the location code, SC Inventory data model requires a location to have the same coordinates. This situation is usually handled by fdsnxml2inv by providing a warning and use only one set of coordinates for all comprised epochs. In our case these informations are not used, so this modification of metadata seems acceptable.
However, the problem we encountered is that the timespans in this situation are then handled in an incoherent way. The station correctly reports an open timespan. On the other hand, the location reports an endtime corrisponding to the first epoch and thus exluding the later two epochs. The two epochs are still retained in the resulting Inventory XML. Below the output from
scinv ls
:This behaviour seems unexpected and may be considered a bug. We understand that SC Inventory cannot represent the original StationXML information unchanged. However, if the change of representation is acceptable, location timespan should be set accordingly.
I attach the problematic files.
CPOZ_failure.tgz
The text was updated successfully, but these errors were encountered: