Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending Processors - private properties #1888

Closed
acdc76 opened this issue May 6, 2024 · 1 comment
Closed

Extending Processors - private properties #1888

acdc76 opened this issue May 6, 2024 · 1 comment
Labels

Comments

@acdc76
Copy link

acdc76 commented May 6, 2024

Monolog version 2

Are the library classes ment to be extended? If so, please make all methods and properties protected instead of private.

I tried to extend IntrospectionProcessor to add a whole callstack, but IntrospectionProcessor has private $level; and others, so it's not possible to extend easily.

@acdc76 acdc76 added the Support label May 6, 2024
@Seldaek
Copy link
Owner

Seldaek commented Jun 28, 2024

I'd say rather send a PR to have a new option on it so everyone interested can benefit, instead of extending.. Otherwise if you don't want to contribute it then just copy the code, it's a very small class and I'd rather keep it more easily maintainable without having to consider extension points.

If you only need Level btw you could override the constructor and store the level on your class as well, then pass it along to parent constructor.

@Seldaek Seldaek closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants