Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #182 - IE scrollbar issue in dropdown (use fix from bbc-fm-nk-core-eng@ea3f067) #370

Closed
wants to merge 2 commits into from

Conversation

benmj
Copy link

@benmj benmj commented Apr 9, 2014

Implements a change that fixes issue in Internet Explorer in which clicking on the scrollbar in the dropdown causes the dropdown to close.

@benmj benmj changed the title Fix bug #182 (use fix from bbc-fm-nk-core-eng@ea3f067) Fix bug #182 - IE scrollbar issue in dropdown (use fix from bbc-fm-nk-core-eng@ea3f067) Apr 9, 2014
@benmj
Copy link
Author

benmj commented Apr 9, 2014

This doesn't entirely solve the user experience -- in Internet Explorer, the <input> loses focus when one clicks on the dropdown's scrollbars. This means that one cannot open the dropdown, click the scrollbars,and then use the type-ahead capabilities.

This issue could be addressed by adding listeners to div.selectize-dropdown-content (which becomes the active element), however it seems like too much of a disturbance for an issue only seen in one browser.

…long, the control maintains it's height. When active, the control will display the right-most portion of the entered data.
@chaliy
Copy link

chaliy commented May 8, 2014

My vote to merge this.

brianreavis added a commit that referenced this pull request Jun 1, 2014
@brianreavis brianreavis closed this Jun 1, 2014
scarfacedeb pushed a commit to scarfacedeb/selectize.js that referenced this pull request Aug 27, 2014
* upstream/master: (69 commits)
  Released 0.11.0.
  Added "allowEmptyOption" option (selectize#163).
  Fixed broken bootstrap3 build.
  Fixing confusing description
  renamed the undefined plugins variable to selector_plugins
  Released 0.10.1.
  Bind createFilter callback to Selectize instance.
  Released 0.10.0.
  Calculate scrollbar width (fixes selectize#360).
  Fix for selectize#438 + tests.
  Added createFilter sample to contacts demo.
  Cherry picked commit 6e04d7b from selectize#370.
  Minor cleanup of selectize#405.
  Forgot self qualifier on
  Jquery cached data allocated by selectized is now cleaned up at destroy time
  Removing extra tabs
  selectized class should not have been added before the classes were checked and propegated to all of the controls created by selectize.  It was previously added after this initialization and is now also added at the same time.
  Used method call to isFull to avoid duplicate code
  Consolidated the refreshState call to capture just becoming full during bulk (or any) addItem call
  Delaying updating attributes and caret during bulk insertion
  ...

Conflicts:
	src/selectize.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants