Added fix to not add "required" attr unless field is actually required. #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianreavis
added a commit
that referenced
this pull request
Jun 1, 2014
scarfacedeb
pushed a commit
to scarfacedeb/selectize.js
that referenced
this pull request
Aug 27, 2014
* upstream/master: (69 commits) Released 0.11.0. Added "allowEmptyOption" option (selectize#163). Fixed broken bootstrap3 build. Fixing confusing description renamed the undefined plugins variable to selector_plugins Released 0.10.1. Bind createFilter callback to Selectize instance. Released 0.10.0. Calculate scrollbar width (fixes selectize#360). Fix for selectize#438 + tests. Added createFilter sample to contacts demo. Cherry picked commit 6e04d7b from selectize#370. Minor cleanup of selectize#405. Forgot self qualifier on Jquery cached data allocated by selectized is now cleaned up at destroy time Removing extra tabs selectized class should not have been added before the classes were checked and propegated to all of the controls created by selectize. It was previously added after this initialization and is now also added at the same time. Used method call to isFull to avoid duplicate code Consolidated the refreshState call to capture just becoming full during bulk (or any) addItem call Delaying updating attributes and caret during bulk insertion ... Conflicts: src/selectize.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the HTML5 spec, the
requiredattribute is a boolean attribute. Just having it present (even if it's value is "false") makes the element required. Most browsers will still work with the attribute set to false, but I've made a very small change to not add the attr at all if the original select does not have therequiredattribute. This should hopefully future-proof it in case browser's change their mind. I've only noticed IE8 marking the field as invalid even withrequired="false".I've added some basic tests along with it, but if you need me to make them more robust, let me know.