Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore escaping commas #836

Conversation

framebassman
Copy link

@framebassman framebassman commented Oct 11, 2018

Proposed changes

Fix for #697

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@framebassman
Copy link
Author

framebassman commented Oct 11, 2018

I think that current suggested solution in issue is not effective due to complex string processing.
I suggest to escape all important commas in arguments via backslash (\) character.

@BorisOsipov
Copy link
Member

BorisOsipov commented Dec 3, 2018

@vinogradoff can you look into this and give your feedback?

@vinogradoff
Copy link
Member

vinogradoff commented Dec 6, 2018

Hm, I think \\, is not intuitive, and only can be used if documented well.

Is Quotes processing really that complex?

Can be done with RegExp, I guess...

@vinogradoff
Copy link
Member

Propose to close - solved in #883

@asolntsev
Copy link
Member

@vinogradoff Can you resolve conflicts?

@vinogradoff
Copy link
Member

Solved with #883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants