Enhanced chromeoptions arguments and preferences #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multiple browsers with Selenide 5.x
| private ChromeOptions transferChromeOptionsFromSystemProperties(Config config, ChromeOptions currentChromeOptions) { | ||
| if (!config.chromeoptionsArgs().equals("")) { | ||
| // Regexp from https://stackoverflow.com/a/15739087/1110503 to handle commas in values | ||
| Stream<String> params = Arrays.stream(config.chromeoptionsArgs().split(",(?=([^\"]*\"[^\"]*\")*[^\"]*$)")); |
|
Agree) that's why I linked Stackoverflow answer with some explanations
Viele Grüße
Alexei Vinogradov
…On 10. December 2018 at 16:31:39, Dmitry Romashov ***@***.***) wrote:
***@***.**** commented on this pull request.
------------------------------
In src/main/java/com/codeborne/selenide/webdriver/ChromeDriverFactory.java
<#883 (comment)>:
> - Map<String, Object> prefs = parsePreferencesFromString(value);
- currentChromeOptions.setExperimentalOption("prefs", prefs);
- break;
- }
- default:
- log.warning(capability + " is ignored." +
- "Only so-called arguments (chromeoptions.args=<values comma separated>) " +
- "and preferences (chromeoptions.prefs=<comma-separated dictionary of key=value> " +
- "are supported for the chromeoptions at the moment");
- break;
- }
- }
+ private ChromeOptions transferChromeOptionsFromSystemProperties(Config config, ChromeOptions currentChromeOptions) {
+ if (!config.chromeoptionsArgs().equals("")) {
+ // Regexp from https://stackoverflow.com/a/15739087/1110503 to handle commas in values
+ Stream<String> params = Arrays.stream(config.chromeoptionsArgs().split(",(?=([^\"]*\"[^\"]*\")*[^\"]*$)"));
really magic regexp
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#883 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGQ4YBMIwUQzjFA1iK74-VbQHfu0iYA0ks5u3n5bgaJpZM4ZKXFY>
.
|
|
@vinogradoff Please resolve conflicts also |
|
@vinogradoff, That's reason of my proposal (#836) |
|
@rosolko resolved |
asolntsev
reviewed
Dec 13, 2018
| @@ -14,6 +14,8 @@ | |||
| String browserBinary(); | |||
| String pageLoadStrategy(); | |||
| DesiredCapabilities browserCapabilities(); | |||
| String chromeoptionsArgs(); | |||
| String chromeoptionsPrefs(); | |||
There was a problem hiding this comment.
I don't like adding the settings. We have too lot of them. And these are chrome-specific settings in the global Config class...
If somebody wants to tune Chrome settings so much, he can just implement WebDriverProvider, right?
rosolko
reviewed
Dec 29, 2018
| * Example: 123,"foo bar","bar,foo" | ||
| * @return values as array, quotes are preserved | ||
| */ | ||
| private String[] parseCSVhandlingQuotes(String csvString) { |
There was a problem hiding this comment.
Not a CSV source, reverts better prefs name
There was a problem hiding this comment.
csv is actually a common abbr for "comma-separated values" - params are csv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Chromeoptions arguments and preferences now allow to have commas in value, when parameter is masked with double quotes. see #836
Also they are made available as Configuration to work smoothly with Selenide 5.+ versions, with multiple browser.
Usage is documented in javadoc and tests.
Checklist
gradle check chrome htmlunitcommand