Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tests to make it easier to modify them #155

Open
ghost opened this issue Aug 9, 2022 · 0 comments
Open

Clean up tests to make it easier to modify them #155

ghost opened this issue Aug 9, 2022 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Aug 9, 2022

In my push to get 100% code coverage, I introduced some unwieldy tests, especially in the pages folder.

There are a lot of table-driven tests in here where the tables are made up of large (many column) tuples with no naming or documentation to know what each column represents. You have to look at the test and try to infer it which is error-prone.

A better way to do this would be to use namedtuples, and update the references in the tests from their index to their column name instead.

@ghost ghost added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers and removed enhancement New feature or request labels Aug 10, 2022
@ghost ghost added this to the Version 23.10.0 milestone Feb 23, 2023
@ghost ghost removed this from the Version 23.10.0 milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

0 participants