Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason for pulp<2.2 #44

Closed
xiki-tempula opened this issue Mar 28, 2022 · 4 comments
Closed

Reason for pulp<2.2 #44

xiki-tempula opened this issue Mar 28, 2022 · 4 comments

Comments

@xiki-tempula
Copy link
Contributor

So I was trying to use conda env during the CI and it seems that the inclusion of pulp<2.2 would force the conda to select the python version to be <3.8. I wonder if there is any reason for this pining? Thanks.

@xiki-tempula
Copy link
Contributor Author

I have removed the pin and it seems Qforce could run fine in py3.8/3.9.

In the CI, I have had an example of running Qforce from xyz file all the way to topology file using the xtb engine https://github.com/selimsami/qforce/blob/05926698f4b30946164e2a080e914ab7bc23fc8d/qforce/tests/test_run_xtb.py. Which seems to show that Qforce could handle the pulp without the pin.

@selimsami
Copy link
Owner

At the time the latest version of pulp was throwing errors (that I can no longer remember). If this is no longer the case, then it might be safe to remove it.

@selimsami
Copy link
Owner

I have removed the pin and it seems Qforce could run fine in py3.8/3.9.

In the CI, I have had an example of running Qforce from xyz file all the way to topology file using the xtb engine https://github.com/selimsami/qforce/blob/05926698f4b30946164e2a080e914ab7bc23fc8d/qforce/tests/test_run_xtb.py. Which seems to show that Qforce could handle the pulp without the pin.

You specifically mentioned 3.8 and 3.9. Is it not working for 3.7?

@xiki-tempula
Copy link
Contributor Author

@selimsami It is only working on 3.7, as pulp==2.1 require python<3.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants