Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any production dependencies on non-master branches? #21

Closed
JanCVanB opened this issue Jan 5, 2022 · 4 comments
Closed

Any production dependencies on non-master branches? #21

JanCVanB opened this issue Jan 5, 2022 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@JanCVanB
Copy link
Member

JanCVanB commented Jan 5, 2022

I'm planning to delete every branch other than master, since they're all either behind (pull-secrets, dev), abandoned (app-launcher-pwa-1, dependabot/npm_and_yarn/images/gce-proxy/src/http-proxy-1.18.1), or replaced by a tag (v1.0.0). Do we know of any production/live environments that depend on those branches?

@JanCVanB JanCVanB added the question Further information is requested label Jan 5, 2022
@danisla
Copy link
Member

danisla commented Jan 5, 2022

These can be removed:

  • app-launcher-pwa-1
  • dependabot/npm_and_yarn/images/gce-proxy/src/http-proxy-1.18.1
  • pull-secrets

Keep the dev branch around though, we'll use that as gitflow to master.

@JanCVanB
Copy link
Member Author

JanCVanB commented Jan 5, 2022

@danisla Do we need to test that it's safe to delete the v1.0.0 branch, now that there's a v1.0.0 tag for the same commit?

I've deleted app-launcher-pwa-1, dependabot/npm_and_yarn/images/gce-proxy/src/http-proxy-1.18.1, and pull-secrets.
I've fast-forwarded dev to meet master.

@danisla
Copy link
Member

danisla commented Jan 5, 2022

@JanCVanB yes should be safe to delete the v1.0.0 branch.

@JanCVanB
Copy link
Member Author

JanCVanB commented Jan 5, 2022

Thanks. Now all of our branches are up-to-date!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants