Fix audio merging when segment doesn't start with a sync byte. #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53
Not sure my heuristic is the best, but I don't see how to do it differently. Let me know if you think it could be improved one way or another (e.g. looking for more than 3 consecutive sync bytes, calculating some checksums, etc…). By the way, my C is a bit rusted. Pardon me if I've made clumsy mistakes and please review carefully.
Also, I think the
hls_download
function leaks memory when the audio segment ends before the video segment. The video segment is never freed in such case. This was not introduced by this PR.