Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change asset bundler #475

Merged
merged 6 commits into from
Mar 6, 2018
Merged

Change asset bundler #475

merged 6 commits into from
Mar 6, 2018

Conversation

twhiston
Copy link
Contributor

@twhiston twhiston commented Mar 5, 2018

resolves #452 by changing the asset bundling to use packr https://github.com/gobuffalo/packr

Note that this change relies on #474 being merged first so that the config file does not need to be made in to an asset (already merged into this branch so that tests can run)

Copy link
Contributor

@strangeman strangeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twhiston twhiston merged commit 285bbd3 into semaphoreui:develop Mar 6, 2018
@twhiston twhiston deleted the change_asset_bundler branch March 6, 2018 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change asset bundler
2 participants