-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forcing local repo checks for 'file://' prefixed repositories - issues/715 #760
Conversation
Thank you @jbkc85 ! |
t.fail() | ||
return | ||
if strings.HasPrefix(t.repository.GitURL, gitURLFilePrefix) { | ||
repositoryPath := strings.TrimPrefix(gitURLFilePrefix, t.repository.GitURL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong way round, the prefix is the 2nd argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh, seriously? I thought I had that appropriately set.
if strings.HasPrefix(t.repository.GitURL, gitURLFilePrefix) { | ||
repositoryPath := strings.TrimPrefix(gitURLFilePrefix, t.repository.GitURL) | ||
if _, err := os.Stat(repositoryPath); err != nil { | ||
t.log("Failed in finding static repository at " + repositoryPath + ": " + err.Error()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should fail() and return here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It should.
No description provided.