Merge Develop into Release #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![r2c-argo[bot]](https://avatars.githubusercontent.com/u/29760937?s=60&v=4){kind=small}
- The regex for scalar strings and lists are different. - Before this change scalar strings did not allow specifying a year, whilst lists must have a year. - After this change a single string may (optionally) have a year, list behaviour is unchanged, a year must be specified.
- I noticed original rule's regex cared about leading zeros. - Restored old behaviour of leading zeros. - Scalar string and list now have consistent behaviour of caring about leading zeros when year is specified. - Scalar string leading year is optional when no year is specified. - Updated test cases.
- Old regex allowed double-zero with year
- Fixes #2754
change domain name
0xDC0DE
approved these changes
Apr 13, 2023
…not-js Fix languages to long names
Allow year in OWASP string for scalar type
add gha trigger for argo workflow
Update generic Gitleak regex to remove false positives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created automatically with the Argo bot using the Argo workflow in release-workflow.yaml